linux-kernel - Re: [PATCH v2 0/3] Bluetooth: hci_qca: Add delay after power-off pulse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOCOHw4sPXTuKEMxRxVXTCE6s2wyyPSqxyOHaPMkUxpZWDThkw@mail.gmail.com>
Date:   Tue, 26 Feb 2019 22:33:03 -0800
From:   Bjorn Andersson <bjorn.andersson@...aro.org>
To:     Matthias Kaehlcke <mka@...omium.org>
Cc:     Marcel Holtmann <marcel@...tmann.org>,
        Johan Hedberg <johan.hedberg@...il.com>,
        "open list:BLUETOOTH DRIVERS" <linux-bluetooth@...r.kernel.org>,
        lkml <linux-kernel@...r.kernel.org>,
        Balakrishna Godavarthi <bgodavar@...eaurora.org>,
        Hemantg <hemantg@...eaurora.org>
Subject: Re: [PATCH v2 0/3] Bluetooth: hci_qca: Add delay after power-off pulse

On Tue, Feb 26, 2019 at 11:47 AM Matthias Kaehlcke <mka@...omium.org> wrote:
>
> Initialization of the QCA WCN3990 often fails at boot time:
>
>  [   15.205224] Bluetooth: hci0: setting up wcn3990
>  [   17.341062] Bluetooth: hci0: command 0xfc00 tx timeout
>  [   22.101453] ERROR: Bluetooth initialization failed
>  [   25.337740] Bluetooth: hci0: Reading QCA version information failed (-110)
>
> A short delay after sending a power-off pulse (which is done immediately
> before sending a power-on pulse) fixes this.
>
> Also move the delays to qca_send_power_pulse(), since they are directly
> related with sending the pulses. Change the interface of
> qca_send_power_pulse() to receive a boolean instead of a power pulse
> command, this improves readability of the function with the delays
> added.
>

For the series:

Reviewed-by: Bjorn Andersson <bjorn.andersson@...aro.org>

Regards,
Bjorn

> Matthias Kaehlcke (3):
>   Bluetooth: hci_qca: Pass boolean 'on/off' to qca_send_power_pulse()
>   Bluetooth: hci_qca: Move boot delay to qca_send_power_pulse()
>   Bluetooth: hci_qca: Add delay after power-off pulse
>
>  drivers/bluetooth/hci_qca.c | 21 +++++++++++----------
>  1 file changed, 11 insertions(+), 10 deletions(-)
>
> --
> 2.21.0.rc2.261.ga7da99ff1b-goog
>