linux-kernel - RE: [PATCH 1/5] ocxl: Rename struct link to ocxl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <156e01d4ce6e$ee42d9f0$cac88dd0$@d-silva.org>
Date:   Wed, 27 Feb 2019 18:34:53 +1100
From:   "Alastair D'Silva" <alastair@...ilva.org>
To:     "'Andrew Donnellan'" <andrew.donnellan@....ibm.com>,
        "'Alastair D'Silva'" <alastair@....ibm.com>
Cc:     "'Greg Kurz'" <groug@...d.org>,
        "'Frederic Barrat'" <fbarrat@...ux.ibm.com>,
        "'Arnd Bergmann'" <arnd@...db.de>,
        "'Greg Kroah-Hartman'" <gregkh@...uxfoundation.org>,
        <linuxppc-dev@...ts.ozlabs.org>, <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 1/5] ocxl: Rename struct link to ocxl_link

> -----Original Message-----
> From: Andrew Donnellan <andrew.donnellan@....ibm.com>
> Sent: Wednesday, 27 February 2019 6:16 PM
> To: Alastair D'Silva <alastair@....ibm.com>; alastair@...ilva.org
> Cc: Greg Kurz <groug@...d.org>; Frederic Barrat <fbarrat@...ux.ibm.com>;
> Arnd Bergmann <arnd@...db.de>; Greg Kroah-Hartman
> <gregkh@...uxfoundation.org>; linuxppc-dev@...ts.ozlabs.org; linux-
> kernel@...r.kernel.org
> Subject: Re: [PATCH 1/5] ocxl: Rename struct link to ocxl_link
> 
> On 27/2/19 3:57 pm, Alastair D'Silva wrote:
> > From: Alastair D'Silva <alastair@...ilva.org>
> >
> > The term 'link' is ambiguous (especially when the struct is used for a
> > list), so rename it for clarity.
> >
> > Signed-off-by: Alastair D'Silva <alastair@...ilva.org>
> > Reviewed-by: Greg Kurz <groug@...d.org>
> > ---
> >   drivers/misc/ocxl/file.c |  2 +-
> >   drivers/misc/ocxl/link.c | 36 ++++++++++++++++++------------------
> >   2 files changed, 19 insertions(+), 19 deletions(-)
> >
> > diff --git a/drivers/misc/ocxl/file.c b/drivers/misc/ocxl/file.c index
> > e6a607488f8a..16eb8a60d5c7 100644
> > --- a/drivers/misc/ocxl/file.c
> > +++ b/drivers/misc/ocxl/file.c
> > @@ -152,7 +152,7 @@ static long afu_ioctl_enable_p9_wait(struct
> > ocxl_context *ctx,
> >
> >   		if (status == ATTACHED) {
> >   			int rc;
> > -			struct link *link = ctx->afu->fn->link;
> > +			void *link = ctx->afu->fn->link;
> 
> This doesn't look like a rename...

That corrects the type to what the member (and prototype for ocxl_link_update_pe) declare it as.

The struct link there is bogus, it shouldn't even compile (since the intended struct link is defined in a different compilation unit), but instead picks up a different definition of 'struct link' from elsewhere.

-- 
Alastair D'Silva           mob: 0423 762 819
skype: alastair_dsilva     msn: alastair@...ilva.org
blog: http://alastair.d-silva.org    Twitter: @EvilDeece