linux-kernel - Re: [PATCH v2] kernel: release ptraced tasks before zap_pid_ns

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <945c0ec2-8e5f-a273-c2cd-3f2fd43a1766@suse.cz>
Date:   Wed, 27 Feb 2019 09:03:35 +0100
From:   Jiri Slaby <jslaby@...e.cz>
To:     Oleg Nesterov <oleg@...hat.com>
Cc:     Andrei Vagin <avagin@...il.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        linux-kernel@...r.kernel.org,
        "Eric W. Biederman" <ebiederm@...ssion.com>
Subject: Re: [PATCH v2] kernel: release ptraced tasks before
 zap_pid_ns_processes

On 26. 02. 19, 16:30, Oleg Nesterov wrote:
>> from our (SUSE) QA we received a report that this patch causes a
>> performance decline in libmicro pthread_* benchmark as reported in:
>> https://bugzilla.suse.com/show_bug.cgi?id=1126762
> 
> Access Denied
> 
>> I tried myself from the repo:
>> https://github.com/redhat-performance/libMicro
>>
>> I ran
>> pthread_create -B 8 -C 200 -S
>>
>> and with the patch applied:
>> # STATISTICS       usecs/call (raw)          usecs/call (outliers removed)
>> #                   mean     23.38611                17.29311
>>
>> Without:
>> #                   mean     41.36539                39.21347
> 
> can't reproduce, I see the same numbers with or without this patch.
> However, I did "./bin/pthread_create -B 8 -C 200 -S" under KVM.

Correct. I did the tests also under KVM. The above difference happens
when you compare (by stupid mistake) a LOCKDEP and non-LOCKDEP kernel --
sorry. So the proper results are comparably the same -- the difference
is on the noise level. So it must be their setup broken too.

Thanks for the input anyway.

-- 
js
suse labs