linux-kernel - Re: [PATCH 1/5] Add support SUNIX Multi-I/O board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190227081723.GA20777@kroah.com>
Date:   Wed, 27 Feb 2019 09:17:23 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Morris Ku <saumah@...il.com>
Cc:     morris_ku@...ix.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/5] Add support SUNIX Multi-I/O board

On Wed, Feb 27, 2019 at 03:17:02PM +0800, Morris Ku wrote:
> Add Kconfig and Makefile entry.
> 
> ---
>  Kconfig  | 2 ++
>  Makefile | 1 +
>  2 files changed, 3 insertions(+)

<snip>

Oh, this series has lots of issues, not the least being this single
patch breaks the build :(

Every patch needs to build properly, or at the least, not stop
everything else from building.

I recommend reading Documentation/SubmittingPatches for how to do a
patch submission properly, and if you have specific questions after
reading that, I will be glad to answer them.

Also, please use scripts/checkpatch.pl on your patches, it will point
out lots of issues that I'll be nice and not mention at the moment :)

thanks,

greg k-h