linux-kernel - Re: [PATCH] Revert "dma-contiguous: do not allocate a single page from CMA area"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJKOXPf_+dME_P9jy5=_LrjYEpgti4+CN0thkSXSvxwSGVH=Bw@mail.gmail.com>
Date:   Wed, 27 Feb 2019 09:46:08 +0100
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Nicolin Chen <nicoleotsuka@...il.com>
Cc:     hch@....de, Marek Szyprowski <m.szyprowski@...sung.com>,
        robin.murphy@....com, tony@...mide.com, vdumpa@...dia.com,
        iommu@...ts.linux-foundation.org, linux-kernel@...r.kernel.org,
        tomi.valkeinen@...com, laurent.pinchart@...asonboard.com,
        sre@...nel.org, linux-arm-kernel@...ts.infradead.org,
        linux-omap@...r.kernel.org, dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH] Revert "dma-contiguous: do not allocate a single page
 from CMA area"

On Tue, 26 Feb 2019 at 21:25, Nicolin Chen <nicoleotsuka@...il.com> wrote:
>
> This reverts commit d222e42e88168fd67e6d131984b86477af1fc256.
>
> The original change breaks omap dss:
>     omapdss_dispc 58001000.dispc:
>         dispc_errata_i734_wa_init: dma_alloc_writecombine failed
>
> Let's revert it first and then find a safer solution instead.
>
> Reported-by: Tony Lindgren <tony@...mide.com>
> Signed-off-by: Nicolin Chen <nicoleotsuka@...il.com>
> ---
> Tony,
>
> Would you please test and verify? Thanks!
>
>  kernel/dma/contiguous.c | 22 +++-------------------
>  1 file changed, 3 insertions(+), 19 deletions(-)

This fixes broken (since yesterday) linux-next on Exynos boards
(ARMv7), errors like:
dma-pl330: probe of 121a0000.pdma failed with error -12
exynos-ehci 12110000.usb: can't setup: -12
exynos-ehci 12110000.usb: USB bus 1 deregistered
exynos-ehci 12110000.usb: Failed to add USB HCD

Tested-by: Krzysztof Kozlowski <krzk@...nel.org>

Best regards,
Krzysztof