lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 27 Feb 2019 10:33:07 +0000
From:   vitor <vitor.soares@...opsys.com>
To:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        Vitor Soares <vitor.soares@...opsys.com>,
        Boris Brezillon <bbrezillon@...nel.org>
CC:     <linux-i3c@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
        Kees Cook <keescook@...omium.org>
Subject: Re: [PATCH] i3c: master: dw-i3c-master: mark expected switch
 fall-through

Hi Gustavo,

Sorry for the delay.

On 27/02/19 03:53, Gustavo A. R. Silva wrote:
> Hi all,
>
> Friendly ping:
>
> Who can ack or review this, please?
>
> Thanks
> --
> Gustavo
>
> On 2/11/19 4:14 PM, Gustavo A. R. Silva wrote:
>> In preparation to enabling -Wimplicit-fallthrough, mark switch
>> cases where we are expecting to fall through.
>>
>> This patch fixes the following warning:
>>
>> drivers/i3c/master/dw-i3c-master.c: In function ‘dw_i3c_master_bus_init’:
>> drivers/i3c/master/dw-i3c-master.c:603:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
>>    if (ret)
>>       ^
>> drivers/i3c/master/dw-i3c-master.c:605:2: note: here
>>   case I3C_BUS_MODE_PURE:
>>   ^~~~
>>
>> Warning level 3 was used: -Wimplicit-fallthrough=3
>>
>> This patch is part of the ongoing efforts to enable
>> -Wimplicit-fallthrough.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
>> ---
>>  drivers/i3c/master/dw-i3c-master.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/i3c/master/dw-i3c-master.c b/drivers/i3c/master/dw-i3c-master.c
>> index bb03079fbade..59279224e07f 100644
>> --- a/drivers/i3c/master/dw-i3c-master.c
>> +++ b/drivers/i3c/master/dw-i3c-master.c
>> @@ -602,6 +602,7 @@ static int dw_i3c_master_bus_init(struct i3c_master_controller *m)
>>  		ret = dw_i2c_clk_cfg(master);
>>  		if (ret)
>>  			return ret;
>> +		/* fall through */
>>  	case I3C_BUS_MODE_PURE:
>>  		ret = dw_i3c_clk_cfg(master);
>>  		if (ret)
>>
Acked-by: Vitor Soares <vitor.soares@...opsys.com>

Best regards,
Vitor Soares

Powered by blists - more mailing lists