linux-kernel - Re: [PATCH 0/2] can: flexcan: add PE clock source select support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d0d2d140-0453-77a5-db6a-88c27f47bbc4@pengutronix.de>
Date:   Wed, 27 Feb 2019 12:00:37 +0100
From:   Marc Kleine-Budde <mkl@...gutronix.de>
To:     Joakim Zhang <qiangqing.zhang@....com>,
        "robh@...nel.org" <robh@...nel.org>
Cc:     "linux-can@...r.kernel.org" <linux-can@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>
Subject: Re: [PATCH 0/2] can: flexcan: add PE clock source select support

On 2/27/19 9:46 AM, Marc Kleine-Budde wrote:
> On 12/13/18 8:07 AM, Joakim Zhang wrote:
>> The patch set intends to add support for PE clock source select. The
>> FlexCAN controller can parse "fsl,clk-source" property from device tree
>> to select clock source.
>>
>> Dong Aisheng (2):
>>   Documentation: can: flexcan: add PE clock source property to device
>>     tree
>>   can: flexcan: add support for PE clock source select
>>
>>  .../bindings/net/can/fsl-flexcan.txt           |  8 ++++++++
>>  drivers/net/can/flexcan.c                      | 18 ++++++++++++++----
>>  2 files changed, 22 insertions(+), 4 deletions(-)
> 
> Added to linux-can-next.

With one change:

> @@ -1369,7 +1371,10 @@ static int register_flexcandev(struct net_device *dev)
>                 goto out_clks_disable;
> 
>         reg = priv->read(&regs->ctrl);
> -       reg |= FLEXCAN_CTRL_CLK_SRC;
> +       if (priv->clk_src)
> +               reg |= FLEXCAN_CTRL_CLK_SRC;
> +       else
> +               reg &= ~FLEXCAN_CTRL_CLK_SRC;

...the FLEXCAN_CTRL_CLK_SRC bit is cleared now.

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |



Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)