linux-kernel - Re: [PATCH 4/5] kbuild: create symlink to vmlinux-gdb.py in scripts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d438549c-91f2-593a-bfa3-4b93bb312a90@ideasonboard.com>
Date:   Wed, 27 Feb 2019 11:48:32 +0000
From:   Kieran Bingham <kieran.bingham@...asonboard.com>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>,
        linux-kbuild@...r.kernel.org
Cc:     Michal Marek <michal.lkml@...kovi.net>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/5] kbuild: create symlink to vmlinux-gdb.py in
 scripts_gdb target

Hi Yamada-san,

On 19/02/2019 09:33, Masahiro Yamada wrote:
> It is weird to create gdb stuff as a side-effect of vmlinux.
> 
> Move it to a more relevant place.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
> ---
> 
>  Makefile | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index a5762c6..0459260 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1015,9 +1015,6 @@ cmd_link-vmlinux =                                                 \
>  	$(if $(ARCH_POSTLINK), $(MAKE) -f $(ARCH_POSTLINK) $@, true)
>  
>  vmlinux: scripts/link-vmlinux.sh autoksyms_recursive $(vmlinux-deps) FORCE
> -ifdef CONFIG_GDB_SCRIPTS
> -	$(Q)ln -fsn $(abspath $(srctree)/scripts/gdb/vmlinux-gdb.py)
> -endif

My initial thought was, doesn't this have a dependency on the vmlinux
... but of course it doesn't. It's not symlinking to the output binary -
it's creating a helper link for GDB to know how to tie in the
scripts-gdb package. It doesn't require vmlinux to exist at all.

So yes, I agree this is fine.


>  	+$(call if_changed,link-vmlinux)
>  
>  targets := vmlinux
> @@ -1519,6 +1516,7 @@ $(DOC_TARGETS): scripts_basic FORCE
>  PHONY += scripts_gdb
>  scripts_gdb: prepare
>  	$(Q)$(MAKE) $(build)=scripts/gdb
> +	$(Q)ln -fsn $(abspath $(srctree)/scripts/gdb/vmlinux-gdb.py)

and especially as we now have this convenient location for it.
This looks much better.

Reviewed-by: Kieran Bingham <kieran.bingham@...asonboard.com>

>  
>  ifdef CONFIG_GDB_SCRIPTS
>  all: scripts_gdb
> 


-- 
Regards
--
Kieran