linux-kernel - Re: [PATCH] drm/bridge: ti-sn65dsi86: make const array static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a10c5be3-9223-a1b7-a3d5-22d7ec6542eb@samsung.com>
Date:   Wed, 27 Feb 2019 13:20:36 +0100
From:   Andrzej Hajda <a.hajda@...sung.com>
To:     Colin King <colin.king@...onical.com>,
        Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        dri-devel@...ts.freedesktop.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/bridge: ti-sn65dsi86: make const array static

On 26.02.2019 17:59, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
>
> Don't populate the const array ti_sn_bridge_supply_names on the
> stack but instead make it static.
>
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
Reviewed-by: Andrzej Hajda <a.hajda@...sung.com>

 --
Regards
Andrzej
> ---
>  drivers/gpu/drm/bridge/ti-sn65dsi86.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> index f72ee137e5f1..4c2ca4e39be5 100644
> --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> @@ -211,7 +211,7 @@ static struct ti_sn_bridge *bridge_to_ti_sn_bridge(struct drm_bridge *bridge)
>  static int ti_sn_bridge_parse_regulators(struct ti_sn_bridge *pdata)
>  {
>  	unsigned int i;
> -	const char * const ti_sn_bridge_supply_names[] = {
> +	static const char * const ti_sn_bridge_supply_names[] = {
>  		"vcca", "vcc", "vccio", "vpll",
>  	};
>