lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 27 Feb 2019 15:34:13 +0200
From:   Adrian Hunter <adrian.hunter@...el.com>
To:     Alamy Liu <alamy.liu@...il.com>,
        Asutosh Das <asutoshd@...eaurora.org>,
        Ritesh Harjani <riteshh@...eaurora.org>,
        Ulf Hansson <ulf.hansson@...aro.org>
Cc:     linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org,
        stable@...r.kernel.org
Subject: Re: [PATCH v2 1/2] mmc: cqhci: fix space allocated for transfer
 descriptor

On 25/02/19 9:22 PM, Alamy Liu wrote:
> There is not enough space being allocated when DCMD is disabled.
> 
> CQE_DCMD is not necessary to be enabled when CQE is enabled.
> (Software could halt CQE to send command)
> 
> In the case that CQE_DCMD is not enabled, it still needs to allocate
> space for data transfer. For instance:
>   CQE_DCMD is enabled:  31 slots space (one slot used by DCMD)
>   CQE_DCMD is disabled: 32 slots space
> 
> Fixes: a4080225f51d ("mmc: cqhci: support for command queue enabled host")
> Signed-off-by: Alamy Liu <alamy.liu@...il.com>

Acked-by: Adrian Hunter <adrian.hunter@...el.com>

> ---
>  drivers/mmc/host/cqhci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/host/cqhci.c b/drivers/mmc/host/cqhci.c
> index 4cc7863c13..974997b6cb 100644
> --- a/drivers/mmc/host/cqhci.c
> +++ b/drivers/mmc/host/cqhci.c
> @@ -202,7 +202,7 @@ static int cqhci_host_alloc_tdl(struct cqhci_host *cq_host)
>  	cq_host->desc_size = cq_host->slot_sz * cq_host->num_slots;
>  
>  	cq_host->data_size = cq_host->trans_desc_len * cq_host->mmc->max_segs *
> -		(cq_host->num_slots - 1);
> +		cq_host->mmc->cqe_qdepth;
>  
>  	pr_debug("%s: cqhci: desc_size: %zu data_sz: %zu slot-sz: %d\n",
>  		 mmc_hostname(cq_host->mmc), cq_host->desc_size, cq_host->data_size,
> 

Powered by blists - more mailing lists