lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 27 Feb 2019 14:39:25 +0100 From: Frederic Barrat <fbarrat@...ux.ibm.com> To: "Alastair D'Silva" <alastair@....ibm.com>, alastair@...ilva.org Cc: Andrew Donnellan <andrew.donnellan@....ibm.com>, Arnd Bergmann <arnd@...db.de>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 5/5] ocxl: Remove some unused exported symbols Le 27/02/2019 à 05:57, Alastair D'Silva a écrit : > From: Alastair D'Silva <alastair@...ilva.org> > > Remove some unused exported symbols. > > Signed-off-by: Alastair D'Silva <alastair@...ilva.org> > --- If you have a respin of the series, that patch also adds a comment around ocxl_context_attach(), which is for later. But in any case: Acked-by: Frederic Barrat <fbarrat@...ux.ibm.com> > drivers/misc/ocxl/config.c | 2 -- > drivers/misc/ocxl/ocxl_internal.h | 26 +++++++++++++++++++++++++- > include/misc/ocxl.h | 23 ----------------------- > 3 files changed, 25 insertions(+), 26 deletions(-) > > diff --git a/drivers/misc/ocxl/config.c b/drivers/misc/ocxl/config.c > index 026ac2ac4f9c..c90c2e4875bf 100644 > --- a/drivers/misc/ocxl/config.c > +++ b/drivers/misc/ocxl/config.c > @@ -299,7 +299,6 @@ int ocxl_config_check_afu_index(struct pci_dev *dev, > } > return 1; > } > -EXPORT_SYMBOL_GPL(ocxl_config_check_afu_index); > > static int read_afu_name(struct pci_dev *dev, struct ocxl_fn_config *fn, > struct ocxl_afu_config *afu) > @@ -535,7 +534,6 @@ int ocxl_config_get_pasid_info(struct pci_dev *dev, int *count) > { > return pnv_ocxl_get_pasid_count(dev, count); > } > -EXPORT_SYMBOL_GPL(ocxl_config_get_pasid_info); > > void ocxl_config_set_afu_pasid(struct pci_dev *dev, int pos, int pasid_base, > u32 pasid_count_log) > diff --git a/drivers/misc/ocxl/ocxl_internal.h b/drivers/misc/ocxl/ocxl_internal.h > index 321b29e77f45..cd5a1e3cc950 100644 > --- a/drivers/misc/ocxl/ocxl_internal.h > +++ b/drivers/misc/ocxl/ocxl_internal.h > @@ -107,10 +107,34 @@ void ocxl_pasid_afu_free(struct ocxl_fn *fn, u32 start, u32 size); > int ocxl_actag_afu_alloc(struct ocxl_fn *fn, u32 size); > void ocxl_actag_afu_free(struct ocxl_fn *fn, u32 start, u32 size); > > +/* > + * Get the max PASID value that can be used by the function > + */ > +int ocxl_config_get_pasid_info(struct pci_dev *dev, int *count); > + > +int ocxl_context_attach(struct ocxl_context *ctx, u64 amr); > + > +/* > + * Check if an AFU index is valid for the given function. > + * > + * AFU indexes can be sparse, so a driver should check all indexes up > + * to the maximum found in the function description > + */ > +int ocxl_config_check_afu_index(struct pci_dev *dev, > + struct ocxl_fn_config *fn, int afu_idx); > + > +/** > + * Update values within a Process Element > + * > + * link_handle: the link handle associated with the process element > + * pasid: the PASID for the AFU context > + * tid: the new thread id for the process element > + */ > +int ocxl_link_update_pe(void *link_handle, int pasid, __u16 tid); > + > struct ocxl_context *ocxl_context_alloc(void); > int ocxl_context_init(struct ocxl_context *ctx, struct ocxl_afu *afu, > struct address_space *mapping); > -int ocxl_context_attach(struct ocxl_context *ctx, u64 amr); > int ocxl_context_mmap(struct ocxl_context *ctx, > struct vm_area_struct *vma); > int ocxl_context_detach(struct ocxl_context *ctx); > diff --git a/include/misc/ocxl.h b/include/misc/ocxl.h > index 4544573cc93c..9530d3be1b30 100644 > --- a/include/misc/ocxl.h > +++ b/include/misc/ocxl.h > @@ -56,15 +56,6 @@ struct ocxl_fn_config { > int ocxl_config_read_function(struct pci_dev *dev, > struct ocxl_fn_config *fn); > > -/* > - * Check if an AFU index is valid for the given function. > - * > - * AFU indexes can be sparse, so a driver should check all indexes up > - * to the maximum found in the function description > - */ > -int ocxl_config_check_afu_index(struct pci_dev *dev, > - struct ocxl_fn_config *fn, int afu_idx); > - > /* > * Read the configuration space of a function for the AFU specified by > * the index 'afu_idx'. Fills in a ocxl_afu_config structure > @@ -74,11 +65,6 @@ int ocxl_config_read_afu(struct pci_dev *dev, > struct ocxl_afu_config *afu, > u8 afu_idx); > > -/* > - * Get the max PASID value that can be used by the function > - */ > -int ocxl_config_get_pasid_info(struct pci_dev *dev, int *count); > - > /* > * Tell an AFU, by writing in the configuration space, the PASIDs that > * it can use. Range starts at 'pasid_base' and its size is a multiple > @@ -188,15 +174,6 @@ int ocxl_link_add_pe(void *link_handle, int pasid, u32 pidr, u32 tidr, > void (*xsl_err_cb)(void *data, u64 addr, u64 dsisr), > void *xsl_err_data); > > -/** > - * Update values within a Process Element > - * > - * link_handle: the link handle associated with the process element > - * pasid: the PASID for the AFU context > - * tid: the new thread id for the process element > - */ > -int ocxl_link_update_pe(void *link_handle, int pasid, __u16 tid); > - > /* > * Remove a Process Element from the Shared Process Area for a link > */ >
Powered by blists - more mailing lists