linux-kernel - Re: [PATCH v7 21/23] block: Avoid that flushing triggers a lockdep complaint

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 27 Feb 2019 23:53:54 +0800
From:   Ming Lei <ming.lei@...hat.com>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     Bart Van Assche <bvanassche@....org>, mingo@...hat.com,
        will.deacon@....com, tj@...nel.org, longman@...hat.com,
        johannes.berg@...el.com, linux-kernel@...r.kernel.org,
        Jens Axboe <axboe@...nel.dk>, Theodore Ts'o <tytso@....edu>
Subject: Re: [PATCH v7 21/23] block: Avoid that flushing triggers a lockdep
 complaint

On Wed, Feb 27, 2019 at 03:24:51PM +0100, Peter Zijlstra wrote:
> On Wed, Feb 27, 2019 at 09:35:56AM +0800, Ming Lei wrote:
> > On Tue, Feb 26, 2019 at 07:08:02PM +0100, Peter Zijlstra wrote:
> > > On Fri, Feb 15, 2019 at 10:26:59AM +0800, Ming Lei wrote:
> > > > There might be lots of blk_flush_queue instance which is allocated
> > > > for each hctx, then lots of class key slot may be wasted.
> > > 
> > > What is 'lots' ? for someone who doesn't really know all that much about
> > > the block layer.
> > 
> > Each hw queue has one instance of blk_flush_queue, and one device may
> > has lots of hw queues(may be > all possible cpus, such as nvme), and there
> > may be lots of block devices in one system.
> > 
> > Suppose one system has 10 NVMe hosts, 8 disks attached to each host, and
> > 256 CPU cores in the system, there can be 10 * 8 * 256 = 20K instances of
> > blk_flush_queue.
> > 
> > Not mention there are other block devices(loop, nbd, scsi, ...) in the system.
> > 
> > That is why I suggest to use one single lock class for addressing this
> > nvme loop specific issue:
> > 
> > https://marc.info/?l=linux-kernel&m=155019765724564&w=2
> 
> Right; that is rather a lot. But what causes the recursion, and thus how
> is it specific to NVME ?

The recursion is nvme-loop specific, see the following link:

https://marc.info/?l=linux-block&m=155003205030566&w=2

Thanks,
Ming