lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 27 Feb 2019 10:14:59 -0800 (PST) From: David Miller <davem@...emloft.net> To: yuehaibing@...wei.com Cc: joe@...ches.com, gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org, netdev@...r.kernel.org Subject: Re: [PATCH] appletalk: Fix use-after-free in atalk_proc_exit From: Yue Haibing <yuehaibing@...wei.com> Date: Wed, 27 Feb 2019 22:59:00 +0800 > @@ -1925,7 +1925,10 @@ static int __init atalk_init(void) > > register_netdevice_notifier(&ddp_notifier); > aarp_proto_init(); > - atalk_proc_init(); > + rc = atalk_proc_init(); > + if (rc) > + goto out; > + > atalk_register_sysctl(); > out: This leaves the netdevice notifier registered etc. You need to add a proper error cleanup code path.
Powered by blists - more mailing lists