linux-kernel - Re: [PATCH -next] appletalk: use remove_proc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201902280258.NGNqGI7X%fengguang.wu@intel.com>
Date:   Thu, 28 Feb 2019 02:32:36 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Yue Haibing <yuehaibing@...wei.com>
Cc:     kbuild-all@...org, davem@...emloft.net, joe@...ches.com,
        gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org, YueHaibing <yuehaibing@...wei.com>
Subject: Re: [PATCH -next] appletalk: use remove_proc_subtree to simplify
 procfs code

Hi YueHaibing,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on next-20190227]

url:    https://github.com/0day-ci/linux/commits/Yue-Haibing/appletalk-use-remove_proc_subtree-to-simplify-procfs-code/20190228-014856
config: xtensa-allyesconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 8.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=8.2.0 make.cross ARCH=xtensa 

All warnings (new ones prefixed by >>):

   net//appletalk/atalk_proc.c: In function 'atalk_proc_init':
>> net//appletalk/atalk_proc.c:218:2: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
     if (!proc_create_seq("atalk/interface", 0444, init_net.proc_net,
     ^~
   net//appletalk/atalk_proc.c:220:3: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
      goto out;
      ^~~~
   net//appletalk/atalk_proc.c:222:2: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
     if (!proc_create_seq("atalk/route", 0444, init_net.proc_net,
     ^~
   net//appletalk/atalk_proc.c:224:3: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
      goto out;
      ^~~~
   net//appletalk/atalk_proc.c:226:2: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
     if (!proc_create_seq("atalk/socket", 0444, init_net.proc_net,
     ^~
   net//appletalk/atalk_proc.c:228:3: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
      goto out;
      ^~~~
   net//appletalk/atalk_proc.c:230:2: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
     if (!proc_create_seq_private("atalk/arp", 0444, init_net.proc_net,
     ^~
   net//appletalk/atalk_proc.c:233:3: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
      goto out;
      ^~~~

vim +/if +218 net//appletalk/atalk_proc.c

   212	
   213	int __init atalk_proc_init(void)
   214	{
   215		if (!proc_mkdir("atalk", init_net.proc_net))
   216			return -ENOMEM;
   217	
 > 218		if (!proc_create_seq("atalk/interface", 0444, init_net.proc_net,
   219				    &atalk_seq_interface_ops));
   220			goto out;
   221	
   222		if (!proc_create_seq("atalk/route", 0444, init_net.proc_net,
   223				    &atalk_seq_route_ops));
   224			goto out;
   225	
   226		if (!proc_create_seq("atalk/socket", 0444, init_net.proc_net,
   227				    &atalk_seq_socket_ops));
   228			goto out;
   229	
   230		if (!proc_create_seq_private("atalk/arp", 0444, init_net.proc_net,
   231					     &aarp_seq_ops,
   232					     sizeof(struct aarp_iter_state), NULL));
   233			goto out;
   234	
   235	out:
   236		remove_proc_subtree("atalk", init_net.proc_net);
   237		return -ENOMEM;
   238	}
   239	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (56809 bytes)