[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20190227200524.GA26912@ravnborg.org>
Date: Wed, 27 Feb 2019 21:05:24 +0100
From: Sam Ravnborg <sam@...nborg.org>
To: Masahiro Yamada <yamada.masahiro@...ionext.com>,
Daniel Vetter <daniel@...ll.ch>
Cc: David Airlie <airlied@...ux.ie>, Daniel Vetter <daniel@...ll.ch>,
dri-devel@...ts.freedesktop.org, amd-gfx@...ts.freedesktop.org,
intel-gvt-dev@...ts.freedesktop.org, nouveau@...ts.freedesktop.org,
linux-arm-msm@...r.kernel.org, intel-gfx@...ts.freedesktop.org,
linux-kernel@...r.kernel.org, Ben Skeggs <bskeggs@...hat.com>,
Rodrigo Vivi <rodrigo.vivi@...el.com>,
Alex Deucher <alexander.deucher@....com>,
freedreno@...ts.freedesktop.org,
Christian König <christian.koenig@....com>,
Zhi Wang <zhi.a.wang@...el.com>
Subject: Re: [PATCH] drm: prefix header search paths with $(srctree)/
Hi Masahiro.
On Thu, Jan 31, 2019 at 12:56:39PM +0900, Masahiro Yamada wrote:
> Currently, the Kbuild core manipulates header search paths in a crazy
> way [1].
>
> To fix this mess, I want all Makefiles to add explicit $(srctree)/ to
> the search paths in the srctree. Some Makefiles are already written in
> that way, but not all. The goal of this work is to make the notation
> consistent, and finally get rid of the gross hacks.
>
> Having whitespaces after -I does not matter since commit 48f6e3cf5bc6
> ("kbuild: do not drop -I without parameter").
>
> [1]: https://patchwork.kernel.org/patch/9632347/
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
Patch looks good:
Reviewed-by: Sam Ravnborg <sam@...nborg.org>
> ---
>
> I put all gpu/drm changes into a single patch because
> they are trivial conversion.
>
> Please let me know if I need to split this into per-driver patches.
Agree that it is good to have those related chnges together in one patch.
I still need to look into getting commit-rights.
Daniel - can you take this to drm-misc?
Sam
Powered by blists - more mailing lists