lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 28 Feb 2019 00:09:58 +0100
From:   Frederic Weisbecker <>
To:     Sebastian Andrzej Siewior <>
Cc:     LKML <>,
        Peter Zijlstra <>,
        Mauro Carvalho Chehab <>,
        Linus Torvalds <>,
        "David S . Miller" <>,
        Thomas Gleixner <>,
        "Paul E . McKenney" <>,
        Frederic Weisbecker <>,
        Pavan Kondeti <>,
        Ingo Molnar <>,
        Joel Fernandes <>
Subject: Re: [PATCH 23/32] softirq: Remove stale comment

On Wed, Feb 27, 2019 at 12:04:04PM +0100, Sebastian Andrzej Siewior wrote:
> On 2019-02-12 18:14:14 [+0100], Frederic Weisbecker wrote:
> > __local_bh_disable_ip() is neither for strict internal use nor does it
> > require the caller to disable hardirqs. Probaby a celebration for ancient
> Probaby
> > behaviour.
> I think the point was to override the IP for the tracer. So everyone
> else used local_bh_disable() and was recorded as the caller except for
> softirq.c internal usage where __do_softirq() did also
> "local_bh_disable()" but recorded its caller (instead recording
> __do_softirq()).

Looks so. Anyway now it's also used by locking functions that need to pass
their own callers. So the comment is stale.

Powered by blists - more mailing lists