linux-kernel - Re: [PATCH] tracing: Fix event filters and triggers to handle negative numbers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190228111908.3c949478@vmware.local.home>
Date:   Thu, 28 Feb 2019 11:19:08 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Pavel Tikhomirov <ptikhomirov@...tuozzo.com>
Cc:     Ingo Molnar <mingo@...hat.com>, Al Viro <viro@...IV.linux.org.uk>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] tracing: Fix event filters and triggers to handle
 negative numbers

On Thu, 28 Feb 2019 09:11:37 +0000
Pavel Tikhomirov <ptikhomirov@...tuozzo.com> wrote:

> ping, looks like the patch was lost
> 
> On 8/24/18 3:48 AM, Steven Rostedt wrote:
> > On Thu, 23 Aug 2018 13:25:34 +0300
> > Pavel Tikhomirov <ptikhomirov@...tuozzo.com> wrote:
> >   
> >> Then tracing syscall exit event it is extremely useful to filter exit
> >> codes equal to some negative value, to react only to required errors.
> >> But negative numbers does not work:
> >>
> >> [root@...rch sys_exit_read]# echo "ret == -1" > filter
> >> bash: echo: write error: Invalid argument
> >> [root@...rch sys_exit_read]# cat filter
> >> ret == -1
> >>          ^
> >> parse_error: Invalid value (did you forget quotes)?  
> > 
> > Thanks for the patch. I'll apply it and then start testing it!

?!?

I remember applying this to my git queue (I don't reply like this
before doing so). Not sure how it got lost. All I can think of is that
it might have been added with commits that ended up failing the tests,
and got reverted with that code :-/

I'm currently traveling. Hopefully I remember tomorrow to add this.
Thanks for pointing this out, and I need to be a bit more careful when
reverting failed commits :-p

-- Steve