linux-kernel - Re: [PATCH] doc: rcu: Suspicious RCU usage is a warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190228165143.GU4072@linux.ibm.com>
Date:   Thu, 28 Feb 2019 08:51:43 -0800
From:   "Paul E. McKenney" <paulmck@...ux.ibm.com>
To:     Geert Uytterhoeven <geert+renesas@...der.be>
Cc:     Jonathan Corbet <corbet@....net>,
        Josh Triplett <josh@...htriplett.org>,
        Steven Rostedt <rostedt@...dmis.org>,
        Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
        Lai Jiangshan <jiangshanlai@...il.com>,
        Joel Fernandes <joel@...lfernandes.org>,
        linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org
Subject: Re: [PATCH] doc: rcu: Suspicious RCU usage is a warning

On Thu, Feb 28, 2019 at 11:59:32AM +0100, Geert Uytterhoeven wrote:
> Suspicious RCU usage messages are reported as warnings.
> 
> Fixes: a5dd63efda3d07b5 ("lockdep: Use "WARNING" tag on lockdep splats")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>

Reviewed-by: Paul E. McKenney <paulmck@...ux.ibm.com>

> ---
> And before that, they were printed as errors, which was also never
> reflected in the documentation...
> ---
>  Documentation/RCU/lockdep-splat.txt | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/RCU/lockdep-splat.txt b/Documentation/RCU/lockdep-splat.txt
> index 9423b633526d14df..9c015976b174123f 100644
> --- a/Documentation/RCU/lockdep-splat.txt
> +++ b/Documentation/RCU/lockdep-splat.txt
> @@ -14,9 +14,9 @@ being the real world and all that.
>  So let's look at an example RCU lockdep splat from 3.0-rc5, one that
>  has long since been fixed:
>  
> -===============================
> -[ INFO: suspicious RCU usage. ]
> --------------------------------
> +=============================
> +WARNING: suspicious RCU usage
> +-----------------------------
>  block/cfq-iosched.c:2776 suspicious rcu_dereference_protected() usage!
>  
>  other info that might help us debug this:
> -- 
> 2.17.1
>