lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 28 Feb 2019 12:27:20 -0800 From: Joe Perches <joe@...ches.com> To: Oscar Gomez Fuente <oscargomezf@...il.com> Cc: gregkh@...uxfoundation.org, devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] staging: rtl8192e: Fix space and suspect issue On Thu, 2019-02-28 at 19:07 +0100, Oscar Gomez Fuente wrote: > These changes fixed a checkpatch error for space required before the > open brace '{' as well as a warning for suspect code indent for > conditional statements. Simple enough, thanks. > diff --git a/drivers/staging/rtl8192e/rtllib_wx.c b/drivers/staging/rtl8192e/rtllib_wx.c [] > @@ -541,8 +541,8 @@ int rtllib_wx_set_encode_ext(struct rtllib_device *ieee, > if (idx < 1 || idx > NUM_WEP_KEYS) trivia: the idx < 1 here test is superfluous as idx is an int masked with 0xff and can't be < 1 if also non-zero Original code: idx = encoding->flags & IW_ENCODE_INDEX; if (idx) { if (idx < 1 || idx > NUM_WEP_KEYS) return -EINVAL; idx--; }
Powered by blists - more mailing lists