linux-kernel - Re: [PATCH] net: ipv6: check net in ip6_call_ra

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190228.130213.1481374802407995712.davem@davemloft.net>
Date:   Thu, 28 Feb 2019 13:02:13 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     fruggeri@...sta.com
Cc:     yoshfuji@...ux-ipv6.org, kuznet@....inr.ac.ru, maxim@...sta.com,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH] net: ipv6: check net in ip6_call_ra_chain

From: fruggeri@...sta.com (Francesco Ruggeri)
Date: Thu, 28 Feb 2019 11:01:46 -0800

> ip6_call_ra_chain is called when IPv6 packet with Router Alert option
> is forwarded.
> It needs to check if the net of the socket is the same as the net of the
> input device, otherwise the packet gets delivered to every IPv6 socket
> listening for Router Alerts, no matter which network namespace it is in.
> 
> Suggested-by: Maxim Martynov <maxim@...sta.com>
> Signed-off-by: Maxim Martynov <maxim@...sta.com>
> Signed-off-by: Francesco Ruggeri <fruggeri@...sta.com>

Right now someone using such a tool does get all RAs in the system.

Your change not only breaks them, but also gives them no method by
which to keep obtaining the same behavior.

I don't know what to do or suggest in this situation, but right now
I'm putting this patch on hold.