lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 28 Feb 2019 15:31:31 -0600
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...hat.com>,
        Namhyung Kim <namhyung@...nel.org>
Cc:     linux-kernel@...r.kernel.org, Kees Cook <keescook@...omium.org>
Subject: Re: [PATCH] perf/core: Mark expected switch fall-through

Hi all,

Friendly ping:

Who can ack or review this, please?

Thanks
--
Gustavo

On 2/12/19 2:54 PM, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch
> cases where we are expecting to fall through.
> 
> This patch fixes the following warning:
> 
> kernel/events/core.c: In function ‘perf_event_parse_addr_filter’:
> kernel/events/core.c:9154:11: warning: this statement may fall through [-Wimplicit-fallthrough=]
>     kernel = 1;
>     ~~~~~~~^~~
> kernel/events/core.c:9156:3: note: here
>    case IF_SRC_FILEADDR:
>    ^~~~
> 
> Warning level 3 was used: -Wimplicit-fallthrough=3
> 
> This patch is part of the ongoing efforts to enable
> -Wimplicit-fallthrough.
> 
> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
> ---
>  kernel/events/core.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/kernel/events/core.c b/kernel/events/core.c
> index ac194d3aae32..343ee21ab958 100644
> --- a/kernel/events/core.c
> +++ b/kernel/events/core.c
> @@ -9152,6 +9152,7 @@ perf_event_parse_addr_filter(struct perf_event *event, char *fstr,
>  		case IF_SRC_KERNELADDR:
>  		case IF_SRC_KERNEL:
>  			kernel = 1;
> +			/* fall through */
>  
>  		case IF_SRC_FILEADDR:
>  		case IF_SRC_FILE:
> 

Powered by blists - more mailing lists