linux-kernel - RE: [RFC PATCH] soc/fsl/qe: support MPC8309

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <VI1PR04MB32475CFE4827D2141262D34E91750@VI1PR04MB3247.eurprd04.prod.outlook.com>
Date:   Thu, 28 Feb 2019 07:14:44 +0000
From:   Qiang Zhao <qiang.zhao@....com>
To:     'Rasmus Villemoes' <rasmus.villemoes@...vas.dk>,
        Leo Li <leoyang.li@....com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Valentin Longchamp <valentin.longchamp@...mile.com>,
        Scott Wood <oss@...error.net>,
        Rasmus Villemoes <Rasmus.Villemoes@...vas.se>
Subject: RE: [RFC PATCH] soc/fsl/qe: support MPC8309

On Tue, Feb 26, 2019 at 2:49 AM Rasmus Villemoes <rasmus.villemoes@...vas.dk> wrote:
> -----Original Message-----
> From: Rasmus Villemoes <rasmus.villemoes@...vas.dk>
> Sent: 2019年2月26日 16:48
> To: Qiang Zhao <qiang.zhao@....com>; Leo Li <leoyang.li@....com>
> Cc: linux-kernel@...r.kernel.org; Valentin Longchamp
> <valentin.longchamp@...mile.com>; Scott Wood <oss@...error.net>;
> Rasmus Villemoes <Rasmus.Villemoes@...vas.se>
> Subject: [RFC PATCH] soc/fsl/qe: support MPC8309
> 
> Currently, when device tree specifies fsl,qe-num-snums = 28 (which a number
> of in-tree .dts files do, and which is the default when that property is missing),
> qe_snums_init() ends up using the first 28 elements of the snum_init_46[]
> array.
> 
> The situation is quite messy. This patch may break existing setups that for
> some reason work with specifying fsl,qe-num-snums = 28 and using the
> existing snum_init_46 array. OTOH, the current code certainly does not work
> for the MPC8309-based board we're working on, since the first 14 of the
> elements in snum_init_46 are "Not available on
> MPC8306/MPC8306S/MPC8309" according to the QUICC Engine Reference
> Manual (Table 4-30) - and indeed, without this patch (or something to the
> same effect), we get

According to the QUICC Engine Reference Manual (Table 4-30), the number of snums used for 
" MPC8306/MPC8306S/MPC8309" should be 14 instead of 28, so maybe we should assign "fsl,qe-num-snums = 14"
And define a new snum_init_14 array, meanwhile, modify the minimum value of "num_of_snums" to 14 in function "qe_get_num_of_snums"
(I mean: " if ((num_of_snums < 14) || (num_of_snums > QE_NUM_OF_SNUM)) {")

Best Regards
Qiang Zhao