linux-kernel - RE: [PATCH V2 2/3] ARM: dts: imx7ulp: add mmdc support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DB3PR0402MB391672641C4829C18DA0DB36F5750@DB3PR0402MB3916.eurprd04.prod.outlook.com>
Date:   Thu, 28 Feb 2019 01:54:41 +0000
From:   Anson Huang <anson.huang@....com>
To:     Fabio Estevam <festevam@...il.com>
CC:     "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        dl-linux-imx <linux-imx@....com>
Subject: RE: [PATCH V2 2/3] ARM: dts: imx7ulp: add mmdc support

Hi, Fabio

Best Regards!
Anson Huang

> -----Original Message-----
> From: Fabio Estevam [mailto:festevam@...il.com]
> Sent: 2019年2月28日 9:32
> To: Anson Huang <anson.huang@....com>
> Cc: robh+dt@...nel.org; mark.rutland@....com; shawnguo@...nel.org;
> s.hauer@...gutronix.de; kernel@...gutronix.de;
> devicetree@...r.kernel.org; linux-kernel@...r.kernel.org; linux-arm-
> kernel@...ts.infradead.org; dl-linux-imx <linux-imx@....com>
> Subject: Re: [PATCH V2 2/3] ARM: dts: imx7ulp: add mmdc support
> 
> Hi Anson,
> 
> On Wed, Feb 27, 2019 at 10:23 PM Anson Huang <anson.huang@....com>
> wrote:
> >
> > i.MX7ULP has a MMDC module to control DDR, it reuses i.MX6Q's MMDC
> > module, add support for it.
> >
> > Signed-off-by: Anson Huang <Anson.Huang@....com>
> > ---
> > Changes since V1:
> >         - use "memory-controller" as MMDC node name to make it more
> generic.
> > ---
> >  arch/arm/boot/dts/imx7ulp.dtsi | 6 ++++++
> >  1 file changed, 6 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/imx7ulp.dtsi
> > b/arch/arm/boot/dts/imx7ulp.dtsi index fca6e50..78f6117 100644
> > --- a/arch/arm/boot/dts/imx7ulp.dtsi
> > +++ b/arch/arm/boot/dts/imx7ulp.dtsi
> > @@ -286,6 +286,12 @@
> >                         status = "disabled";
> >                 };
> >
> > +               mmdc: memory-controller@...b0000 {
> 
> It seems that the 'mmdc' label is not neeed.
> 
> You could make it simpler as:
> 
> memory-controller@...b0000 {

If so, should I change other i.MX6 SoCs with single MMDC node as well?
Remove them as well?

Anson.