linux-kernel - Re: [tip:x86/build] x86, retpolines: Raise limit for generating indirect calls from switch-case

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <33bf951448e7d916fd4a6ad41cd3d040e9d1f118.camel@infradead.org>
Date:   Thu, 28 Feb 2019 11:27:17 +0000
From:   David Woodhouse <dwmw2@...radead.org>
To:     daniel@...earbox.net, mingo@...nel.org, bjorn.topel@...el.com,
        davem@...emloft.net, brouer@...hat.com, magnus.karlsson@...el.com,
        luto@...nel.org, hpa@...or.com, tglx@...utronix.de,
        peterz@...radead.org, bp@...en8.de, torvalds@...ux-foundation.org,
        linux-kernel@...r.kernel.org, ast@...nel.org,
        linux-tip-commits@...r.kernel.org
Cc:     hjl.tools@...il.com
Subject: Re: [tip:x86/build] x86, retpolines: Raise limit for generating
 indirect calls from switch-case

On Thu, 2019-02-28 at 03:12 -0800, tip-bot for Daniel Borkmann wrote:
> Commit-ID:  ce02ef06fcf7a399a6276adb83f37373d10cbbe1
> Gitweb:     https://git.kernel.org/tip/ce02ef06fcf7a399a6276adb83f37373d10cbbe1
> Author:     Daniel Borkmann <daniel@...earbox.net>
> AuthorDate: Thu, 21 Feb 2019 23:19:41 +0100
> Committer:  Thomas Gleixner <tglx@...utronix.de>
> CommitDate: Thu, 28 Feb 2019 12:10:31 +0100
> 
> x86, retpolines: Raise limit for generating indirect calls from switch-case
> 
> From networking side, there are numerous attempts to get rid of indirect
> calls in fast-path wherever feasible in order to avoid the cost of
> retpolines, for example, just to name a few:
> 
>   * 283c16a2dfd3 ("indirect call wrappers: helpers to speed-up indirect calls of builtin")
>   * aaa5d90b395a ("net: use indirect call wrappers at GRO network layer")
>   * 028e0a476684 ("net: use indirect call wrappers at GRO transport layer")
>   * 356da6d0cde3 ("dma-mapping: bypass indirect calls for dma-direct")
>   * 09772d92cd5a ("bpf: avoid retpoline for lookup/update/delete calls on maps")
>   * 10870dd89e95 ("netfilter: nf_tables: add direct calls for all builtin expressions")
>   [...]
> 
> Recent work on XDP from Björn and Magnus additionally found that manually
> transforming the XDP return code switch statement with more than 5 cases
> into if-else combination would result in a considerable speedup in XDP
> layer due to avoidance of indirect calls in CONFIG_RETPOLINE enabled
> builds. 

+HJL

This is a GCC bug, surely? It should know how expensive each
instruction is, and choose which to use accordingly. That should be
true even when the indirect branch "instruction" is a retpoline, and
thus enormously expensive.

I believe this is https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86952 so
please at least reference that bug, and be prepared to turn this hack
off when GCC is fixed.

Download attachment "smime.p7s" of type "application/x-pkcs7-signature" (5174 bytes)