linux-kernel - Re: [PATCH v7 1/7] ARM: trusted_foundations: Support L2 cache maintenance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ba215d63-ffaa-5be6-c43f-fdb845b1d6b7@gmail.com>
Date:   Thu, 28 Feb 2019 16:36:49 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Russell King - ARM Linux admin <linux@...linux.org.uk>
Cc:     Thierry Reding <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Robert Yang <decatf@...il.com>,
        Michał Mirosław <mirq-linux@...e.qmqm.pl>,
        linux-arm-kernel@...ts.infradead.org, linux-tegra@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v7 1/7] ARM: trusted_foundations: Support L2 cache
 maintenance

28.02.2019 16:27, Russell King - ARM Linux admin пишет:
> On Thu, Feb 28, 2019 at 04:17:01PM +0300, Dmitry Osipenko wrote:
>> +#ifdef CONFIG_CACHE_L2X0
>> +static void tf_cache_write_sec(unsigned long val, unsigned int reg)
>> +{
>> +	u32 l2x0_way_mask = 0xff;
>> +
>> +	switch (reg) {
>> +	case L2X0_CTRL:
>> +		if (l2x0_saved_regs.aux_ctrl & BIT(16))
> 
> And bit 16 is what?  We have definitions in one of the headers you've
> added above, please use them.  Thanks.
> 

Good catch, I missed that there is a definition for that bit. I'll make a v8 soon'ish, please let me know if there is anything else to be addressed. Yours r-b and a-b will be appreciated.