linux-kernel - RE: [PATCH 03/11] regulator: da9055: Convert to use regulator_set/get_current_limit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <VI1PR10MB23528759982DFF51AAF475D7FE750@VI1PR10MB2352.EURPRD10.PROD.OUTLOOK.COM>
Date:   Thu, 28 Feb 2019 15:18:07 +0000
From:   Steve Twiss <stwiss.opensource@...semi.com>
To:     Axel Lin <axel.lin@...ics.com>, Mark Brown <broonie@...nel.org>
CC:     Support Opensource <Support.Opensource@...semi.com>,
        "patches@...nsource.cirrus.com" <patches@...nsource.cirrus.com>,
        Ashish Jangam <ashish.jangam@...tcummins.com>,
        Steve Twiss <stwiss.opensource@...semi.com>,
        Paul Kocialkowski <contact@...lk.fr>,
        Milo Kim <milo.kim@...com>, Keerthy <j-keerthy@...com>,
        James Seong-Won Ban <James.Ban.opensource@...semi.com>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 03/11] regulator: da9055: Convert to use
 regulator_set/get_current_limit_regmap

On 28 February 2019 13:40, Axel Lin,

> Subject: [PATCH 03/11] regulator: da9055: Convert to use
> regulator_set/get_current_limit_regmap
> 
> Use regulator_set/get_current_limit_regmap helpers to save some code.

[...]

> @@ -329,8 +298,8 @@ static const struct regulator_ops da9055_buck_ops = {
>  	.get_mode = da9055_buck_get_mode,
>  	.set_mode = da9055_buck_set_mode,
> 
> -	.get_current_limit = da9055_buck_get_current_limit,
> -	.set_current_limit = da9055_buck_set_current_limit,
> +	.get_current_limit = regulator_get_current_limit_regmap,
> +	.set_current_limit = regulator_set_current_limit_regmap,
> 
>  	.get_voltage_sel = da9055_regulator_get_voltage_sel,
>  	.set_voltage_sel = da9055_regulator_set_voltage_sel,
> @@ -407,6 +376,10 @@ static const struct regulator_ops da9055_ldo_ops = {
>  		.uV_step = (step) * 1000,\
>  		.linear_min_sel = (voffset),\
>  		.owner = THIS_MODULE,\
> +		.curr_table = da9055_current_limits,\
> +		.n_current_limits = ARRAY_SIZE(da9055_current_limits),\
> +		.csel_reg = DA9055_REG_BUCK_LIM,\
> +		.csel_mask = (mbits),\

Hi Axel, 

Thanks.

Acked-by: Steve Twiss <stwiss.opensource@...semi.com>

Regards,
Steve