linux-kernel - Re: [PATCH AUTOSEL 4.20 43/81] blk-mq: protect debugfs_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190228152607.GE8481@kroah.com>
Date:   Thu, 28 Feb 2019 16:26:07 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Sasha Levin <sashal@...nel.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        linux-block@...r.kernel.org
Subject: Re: [PATCH AUTOSEL 4.20 43/81] blk-mq: protect
 debugfs_create_files() from failures

On Thu, Feb 28, 2019 at 10:07:35AM -0500, Sasha Levin wrote:
> From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> 
> [ Upstream commit 36991ca68db9dd43bac7f3519f080ee3939263ef ]
> 
> If debugfs were to return a non-NULL error for a debugfs call, using
> that pointer later in debugfs_create_files() would crash.
> 
> Fix that by properly checking the pointer before referencing it.
> 
> Reported-by: Michal Hocko <mhocko@...nel.org>
> Reported-and-tested-by: syzbot+b382ba6a802a3d242790@...kaller.appspotmail.com
> Reported-by: Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Signed-off-by: Sasha Levin <sashal@...nel.org>
> ---
>  block/blk-mq-debugfs.c | 3 +++
>  1 file changed, 3 insertions(+)
> 

As the commit this "fixes" should not be backported, no need for this
patch in any stable kernel either.  Please drop from all queues.

thanks,

greg k-h