linux-kernel - Re: [PATCH AUTOSEL 4.20 42/81] relay: check return of create_buf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190228152621.GF8481@kroah.com>
Date:   Thu, 28 Feb 2019 16:26:21 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Sasha Levin <sashal@...nel.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>,
        David Rientjes <rientjes@...gle.com>
Subject: Re: [PATCH AUTOSEL 4.20 42/81] relay: check return of
 create_buf_file() properly

On Thu, Feb 28, 2019 at 10:07:34AM -0500, Sasha Levin wrote:
> From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> 
> [ Upstream commit 2c1cf00eeacb784781cf1c9896b8af001246d339 ]
> 
> If create_buf_file() returns an error, don't try to reference it later
> as a valid dentry pointer.
> 
> This problem was exposed when debugfs started to return errors instead
> of just NULL for some calls when they do not succeed properly.
> 
> Also, the check for WARN_ON(dentry) was just wrong :)
> 
> Reported-by: Kees Cook <keescook@...omium.org>
> Reported-and-tested-by: syzbot+16c3a70e1e9b29346c43@...kaller.appspotmail.com
> Reported-by: Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: David Rientjes <rientjes@...gle.com>
> Fixes: ff9fb72bc077 ("debugfs: return error values, not NULL")
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Signed-off-by: Sasha Levin <sashal@...nel.org>
> ---
>  kernel/relay.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

Same here as well, please drop this from all queues.

greg k-h