linux-kernel - Re: [PATCH] perf c2c: Fix c2c report for empty numa node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 1 Mar 2019 12:35:39 +0530
From:   Ravi Bangoria <ravi.bangoria@...ux.ibm.com>
To:     Jiri Olsa <jolsa@...hat.com>
Cc:     acme@...nel.org, alexander.shishkin@...ux.intel.com,
        namhyung@...nel.org, eranian@...gle.com,
        linux-kernel@...r.kernel.org, tonyj@...e.com, nasastry@...ibm.com,
        Ravi Bangoria <ravi.bangoria@...ux.ibm.com>
Subject: Re: [PATCH] perf c2c: Fix c2c report for empty numa node


On 2/28/19 9:52 PM, Jiri Olsa wrote:
> how about attached change (untested)?

LGTM. Would you mind sending a patch.

> 
> but I wonder there are some other hidden
> bugs wrt empty node
> 
> jirka
> 
> 
> ---
> diff --git a/tools/perf/builtin-c2c.c b/tools/perf/builtin-c2c.c
> index 4272763a5e96..9e6cc868bdb4 100644
> --- a/tools/perf/builtin-c2c.c
> +++ b/tools/perf/builtin-c2c.c
> @@ -2056,6 +2056,12 @@ static int setup_nodes(struct perf_session *session)
>  		if (!set)
>  			return -ENOMEM;
>  
> +		nodes[node] = set;
> +
> +		/* empty node, skip */
> +		if (cpu_map__empty(map))
> +			continue;
> +
>  		for (cpu = 0; cpu < map->nr; cpu++) {
>  			set_bit(map->map[cpu], set);
>  
> @@ -2064,8 +2070,6 @@ static int setup_nodes(struct perf_session *session)
>  
>  			cpu2node[map->map[cpu]] = node;
>  		}
> -
> -		nodes[node] = set;
>  	}
>  
>  	setup_nodes_header();
>