linux-kernel - Re: [PATCH v2] mfd: cros_ec: instantiate properly CrOS ISH MCU device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190301084234.GA632@intel.com>
Date:   Fri, 1 Mar 2019 14:12:34 +0530
From:   Rushikesh S Kadam <rushikesh.s.kadam@...el.com>
To:     Andy Shevchenko <andriy.shevchenko@...el.com>
Cc:     lee.jones@...aro.org, bleung@...omium.org,
        enric.balletbo@...labora.com, groeck@...omium.org,
        linux-kernel@...r.kernel.org, gwendal@...gle.com,
        jettrink@...omium.org
Subject: Re: [PATCH v2] mfd: cros_ec: instantiate properly CrOS ISH MCU device

Hi Andy

On Fri, Mar 01, 2019 at 09:28:11AM +0200, Andy Shevchenko wrote:
> On Fri, Mar 01, 2019 at 09:36:11AM +0530, Rushikesh S Kadam wrote:
> > Integrated Sensor Hub (ISH) is also a MCU running EC
> > having feature bit EC_FEATURE_ISH. Instantiate it as
> > a special CrOS EC device with device name 'cros_ish'.
> 
> > v2
> > - Addressed review comments to term the CrOS EC device as a generic
> >   Integrated Sensor Hub. 
> 
> > +	/* The MCU is an Intel Integrated Sensor Hub */
> 
> This has to be adjusted as well. Intel ISH is just one of the example of ISHs.

Thanks for the catch

I submitted v3 with this fixed

Regards
Rushikesh

> 
> > +	EC_FEATURE_ISH = 40,
> 
> -- 
> With Best Regards,
> Andy Shevchenko
> 
> 

--