lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 1 Mar 2019 16:56:50 +0800 From: Wen Yang <wen.yang99@....com.cn> To: liviu.dudau@....com Cc: sudeep.holla@....com, lorenzo.pieralisi@....com, linux@...linux.org.uk, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, kgene@...nel.org, krzk@...nel.org, linux-samsung-soc@...r.kernel.org, michal.simek@...inx.com, afaerber@...e.de, manivannan.sadhasivam@...aro.org, dinguyen@...nel.org, heiko@...ech.de, linux-rockchip@...ts.infradead.org, f.fainelli@...il.com, rjui@...adcom.com, sbranden@...adcom.com, bcm-kernel-feedback-list@...adcom.com, linus.walleij@...aro.org, avifishman70@...il.com, tmaimon77@...il.com, venture@...gle.com, yuenn@...gle.com, brendanhiggins@...gle.com, openbmc@...ts.ozlabs.org, xuwei5@...ilicon.com, maxime.ripard@...tlin.com, wens@...e.org, catalin.marinas@....com, will.deacon@....com, horms@...ge.net.au, magnus.damm@...il.com, linux-renesas-soc@...r.kernel.org, shawnguo@...nel.org, s.hauer@...gutronix.de, kernel@...gutronix.de, fabio.estevam@....com, linux-imx@....com, wang.yi59@....com.cn, Wen Yang <wen.yang99@....com.cn> Subject: [PATCH 09/15] ARM: socfpga: fix a leaked reference by addingmissing of_node_put The call to of_get_next_child returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage. Detected by coccinelle with the following warnings: ./arch/arm/mach-socfpga/platsmp.c:93:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 85, but without a corresponding object release within this function. Signed-off-by: Wen Yang <wen.yang99@....com.cn> Cc: Dinh Nguyen <dinguyen@...nel.org> Cc: Russell King <linux@...linux.org.uk> Cc: linux-arm-kernel@...ts.infradead.org Cc: linux-kernel@...r.kernel.org --- arch/arm/mach-socfpga/platsmp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-socfpga/platsmp.c b/arch/arm/mach-socfpga/platsmp.c index 0ee7677..55c2884 100644 --- a/arch/arm/mach-socfpga/platsmp.c +++ b/arch/arm/mach-socfpga/platsmp.c @@ -89,6 +89,7 @@ static void __init socfpga_smp_prepare_cpus(unsigned int max_cpus) } socfpga_scu_base_addr = of_iomap(np, 0); + of_node_put(np); if (!socfpga_scu_base_addr) return; scu_enable(socfpga_scu_base_addr); -- 2.9.5
Powered by blists - more mailing lists