linux-kernel - [PATCH 10/15] ARM: sunxi: fix a leaked reference by addingmissing of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 1 Mar 2019 16:56:51 +0800
From:   Wen Yang <wen.yang99@....com.cn>
To:     liviu.dudau@....com
Cc:     sudeep.holla@....com, lorenzo.pieralisi@....com,
        linux@...linux.org.uk, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, kgene@...nel.org, krzk@...nel.org,
        linux-samsung-soc@...r.kernel.org, michal.simek@...inx.com,
        afaerber@...e.de, manivannan.sadhasivam@...aro.org,
        dinguyen@...nel.org, heiko@...ech.de,
        linux-rockchip@...ts.infradead.org, f.fainelli@...il.com,
        rjui@...adcom.com, sbranden@...adcom.com,
        bcm-kernel-feedback-list@...adcom.com, linus.walleij@...aro.org,
        avifishman70@...il.com, tmaimon77@...il.com, venture@...gle.com,
        yuenn@...gle.com, brendanhiggins@...gle.com,
        openbmc@...ts.ozlabs.org, xuwei5@...ilicon.com,
        maxime.ripard@...tlin.com, wens@...e.org, catalin.marinas@....com,
        will.deacon@....com, horms@...ge.net.au, magnus.damm@...il.com,
        linux-renesas-soc@...r.kernel.org, shawnguo@...nel.org,
        s.hauer@...gutronix.de, kernel@...gutronix.de,
        fabio.estevam@....com, linux-imx@....com, wang.yi59@....com.cn,
        Wen Yang <wen.yang99@....com.cn>
Subject: [PATCH 10/15] ARM: sunxi: fix a leaked reference by addingmissing of_node_put

The call to of_get_next_child returns a node pointer with refcount
incremented thus it must be explicitly decremented after the last
usage.

Detected by coccinelle with the following warnings:
./arch/arm/mach-sunxi/platsmp.c:55:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 46, but without a corresponding object release within this function.
./arch/arm/mach-sunxi/platsmp.c:138:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 129, but without a corresponding object release within this function.

Signed-off-by: Wen Yang <wen.yang99@....com.cn>
Cc: Maxime Ripard <maxime.ripard@...tlin.com>
Cc: Chen-Yu Tsai <wens@...e.org>
Cc: Russell King <linux@...linux.org.uk>
Cc: linux-arm-kernel@...ts.infradead.org
Cc: linux-kernel@...r.kernel.org
---
 arch/arm/mach-sunxi/platsmp.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/mach-sunxi/platsmp.c b/arch/arm/mach-sunxi/platsmp.c
index 8fb5088..c842209 100644
--- a/arch/arm/mach-sunxi/platsmp.c
+++ b/arch/arm/mach-sunxi/platsmp.c
@@ -50,6 +50,7 @@ static void __init sun6i_smp_prepare_cpus(unsigned int max_cpus)
 	}
 
 	prcm_membase = of_iomap(node, 0);
+	of_node_put(node);
 	if (!prcm_membase) {
 		pr_err("Couldn't map A31 PRCM registers\n");
 		return;
@@ -63,6 +64,7 @@ static void __init sun6i_smp_prepare_cpus(unsigned int max_cpus)
 	}
 
 	cpucfg_membase = of_iomap(node, 0);
+	of_node_put(node);
 	if (!cpucfg_membase)
 		pr_err("Couldn't map A31 CPU config registers\n");
 
-- 
2.9.5