lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 1 Mar 2019 16:56:55 +0800
From:   Wen Yang <wen.yang99@....com.cn>
To:     liviu.dudau@....com
Cc:     sudeep.holla@....com, lorenzo.pieralisi@....com,
        linux@...linux.org.uk, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, kgene@...nel.org, krzk@...nel.org,
        linux-samsung-soc@...r.kernel.org, michal.simek@...inx.com,
        afaerber@...e.de, manivannan.sadhasivam@...aro.org,
        dinguyen@...nel.org, heiko@...ech.de,
        linux-rockchip@...ts.infradead.org, f.fainelli@...il.com,
        rjui@...adcom.com, sbranden@...adcom.com,
        bcm-kernel-feedback-list@...adcom.com, linus.walleij@...aro.org,
        avifishman70@...il.com, tmaimon77@...il.com, venture@...gle.com,
        yuenn@...gle.com, brendanhiggins@...gle.com,
        openbmc@...ts.ozlabs.org, xuwei5@...ilicon.com,
        maxime.ripard@...tlin.com, wens@...e.org, catalin.marinas@....com,
        will.deacon@....com, horms@...ge.net.au, magnus.damm@...il.com,
        linux-renesas-soc@...r.kernel.org, shawnguo@...nel.org,
        s.hauer@...gutronix.de, kernel@...gutronix.de,
        fabio.estevam@....com, linux-imx@....com, wang.yi59@....com.cn,
        Wen Yang <wen.yang99@....com.cn>
Subject: [PATCH 14/15] arm64: cpu_ops: fix a leaked reference by addingmissing of_node_put

The call to of_get_next_child returns a node pointer with refcount
incremented thus it must be explicitly decremented after the last
usage.

Detected by coccinelle with the following warnings:
./arch/arm64/kernel/cpu_ops.c:102:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 69, but without a corresponding object release within this function.

Signed-off-by: Wen Yang <wen.yang99@....com.cn>
Cc: Catalin Marinas <catalin.marinas@....com>
Cc: Will Deacon <will.deacon@....com>
Cc: linux-arm-kernel@...ts.infradead.org
Cc: linux-kernel@...r.kernel.org
---
 arch/arm64/kernel/cpu_ops.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/kernel/cpu_ops.c b/arch/arm64/kernel/cpu_ops.c
index ea00124..00f8b86 100644
--- a/arch/arm64/kernel/cpu_ops.c
+++ b/arch/arm64/kernel/cpu_ops.c
@@ -85,6 +85,7 @@ static const char *__init cpu_read_enable_method(int cpu)
 				pr_err("%pOF: missing enable-method property\n",
 					dn);
 		}
+		of_node_put(dn);
 	} else {
 		enable_method = acpi_get_enable_method(cpu);
 		if (!enable_method) {
-- 
2.9.5

Powered by blists - more mailing lists