linux-kernel - Re: [PATCH] nvme-pci: Prevent mmio reads if pci channel offline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <06eb10e5a7324bb5ac537fd57e015d73@AUSX13MPC131.AMER.DELL.COM>
Date:   Fri, 1 Mar 2019 01:52:02 +0000
From:   <Austin.Bolen@...l.com>
To:     <kbusch@...nel.org>, <Austin.Bolen@...l.com>
CC:     <hch@...radead.org>, <Alex_Gagniuc@...lteam.com>,
        <torvalds@...ux-foundation.org>, <keith.busch@...el.com>,
        <sagi@...mberg.me>, <linux-kernel@...r.kernel.org>,
        <linux-nvme@...ts.infradead.org>, <axboe@...com>,
        <mr.nuke.me@...il.com>, <hch@....de>, <jonathan.derrick@...el.com>
Subject: Re: [PATCH] nvme-pci: Prevent mmio reads if pci channel offline

On 2/28/2019 6:30 PM, Keith Busch wrote:
> 
> For single port drives, yes, but that wouldn't work so well for multi-port
> devices connected to different busses, maybe even across multiple hosts.
> The equivalent of an FLR across all ports should have been sufficient,
> IMO.
> 

In that case I'd argue that it really is a surprise down to the other 
host and escalating as such is appropriate.  Agree that something like 
FLR that reset everything in the subsystem but kept link up may have 
been sufficient.