lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri,  1 Mar 2019 14:03:34 +0000
From:   Will Deacon <>
Cc:, Will Deacon <>,
        "Paul E. McKenney" <>,
        Benjamin Herrenschmidt <>,
        Michael Ellerman <>,
        Arnd Bergmann <>,
        Peter Zijlstra <>,
        Andrea Parri <>,
        Palmer Dabbelt <>,
        Daniel Lustig <>,
        David Howells <>,
        Alan Stern <>,
        Linus Torvalds <>,
        "Maciej W. Rozycki" <>,
        Paul Burton <>,
        Ingo Molnar <>,
        Yoshinori Sato <>,
        Rich Felker <>, Tony Luck <>
Subject: [PATCH 06/20] x86/io: Remove useless definition of mmiowb()

x86 maps mmiowb() to barrier(), but this is superfluous because a
compiler barrier is already implied by spin_unlock(). Since x86 also
includes asm-generic/io.h in its asm/io.h file, we can remove the
definition entirely and pick up the dummy definition from core code.

Signed-off-by: Will Deacon <>
 arch/x86/include/asm/io.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/x86/include/asm/io.h b/arch/x86/include/asm/io.h
index 686247db3106..a06a9f8294ea 100644
--- a/arch/x86/include/asm/io.h
+++ b/arch/x86/include/asm/io.h
@@ -90,8 +90,6 @@ build_mmio_write(__writel, "l", unsigned int, "r", )
 #define __raw_writew __writew
 #define __raw_writel __writel
-#define mmiowb() barrier()
 #ifdef CONFIG_X86_64
 build_mmio_read(readq, "q", u64, "=r", :"memory")

Powered by blists - more mailing lists