linux-kernel - Re: [PATCH] crypto: s5p-sss - fix AES support for Exynos5433

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJKOXPc_=Y=FNZXuDnVh72Wxt_+MS+jonVW7pb+vXiJ-ctGCvw@mail.gmail.com>
Date:   Fri, 1 Mar 2019 15:18:11 +0100
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Kamil Konieczny <k.konieczny@...tner.samsung.com>
Cc:     Herbert Xu <herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>,
        Vladimir Zapolskiy <vz@...ia.com>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        Marek Szyprowski <m.szyprowski@...sung.com>,
        linux-crypto@...r.kernel.org,
        "linux-samsung-soc@...r.kernel.org" 
        <linux-samsung-soc@...r.kernel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] crypto: s5p-sss - fix AES support for Exynos5433

On Fri, 1 Mar 2019 at 15:03, Kamil Konieczny
<k.konieczny@...tner.samsung.com> wrote:
>
> Commit 0918f18c7179 ("crypto: s5p - add AES support for Exynos5433")
> introduced bug in dereferencing clk_names[1] on platforms different from
> Exynos5433. On Exynos board XU3 call trace is:
>
> "Unable to handle kernel paging request at virtual address 00004000"
> (strcmp) from [<c0774014>] (of_property_match_string+0x58/0xd0)
> ...
> (devm_clk_get) from [<c075c248>] (s5p_aes_probe+0xd4/0x4a0)
> (s5p_aes_probe) from [<c059dbc4>] (platform_drv_probe+0x6c/0xa4)
>
> Fix this by setting array clk_names size to 2.
>
> Fixes: 0918f18c7179 ("crypto: s5p - add AES support for Exynos5433")
> Reported-by: Krzysztof Kozlowski <krzk@...nel.org>
> Signed-off-by: Kamil Konieczny <k.konieczny@...tner.samsung.com>
> ---
>  drivers/crypto/s5p-sss.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks for fast fix!

Reviewed-by: Krzysztof Kozlowski <krzk@...nel.org>
Tested on Exynos5422 Odroid HC1:
Tested-by: Krzysztof Kozlowski <krzk@...nel.org>

Best regards,
Krzysztof