linux-kernel - Re: [PATCH v5 2/2] i2c: designware: Add support for an interface clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <080b8edd-168e-d71a-b4c2-985460a51e53@linux.intel.com>
Date:   Fri, 1 Mar 2019 16:53:07 +0200
From:   Jarkko Nikula <jarkko.nikula@...ux.intel.com>
To:     Gareth Williams <gareth.williams.jx@...esas.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        linux-i2c@...r.kernel.org
Cc:     Phil Edworthy <phil.edworthy@...esas.com>,
        linux-kernel@...r.kernel.org, linux-renesas-soc@...r.kernel.org
Subject: Re: [PATCH v5 2/2] i2c: designware: Add support for an interface
 clock

On 2/28/19 3:52 PM, Gareth Williams wrote:
> From: Phil Edworthy <phil.edworthy@...esas.com>
> 
> The Synopsys I2C Controller has an interface clock, but most SoCs hide
> this away. However, on some SoCs you need to explicitly enable the
> interface clock in order to access the registers. Therefore, add
> support for an optional interface clock.
> 
> Signed-off-by: Phil Edworthy <phil.edworthy@...esas.com>
> Signed-off-by: Gareth Williams <gareth.williams.jx@...esas.com>
> Acked-by: Wolfram Sang <wsa+renesas@...g-engineering.com>
> ---
> v5:
>   - Updated comments to reference "interface clock" instead of
>     "peripheral clock".
>   - Corrected spelling in commit message, changing "explicity" to
>     "explicitly".
> v4:
>   - Updated comments to reference "peripheral clock"
>     instead of "bus clock".
>   - Added Wolfram's Acked-by
> v3:
>   - busclk renamed to pclk.
>   - Added comment with dw_i2c_dev struct definition describing pclk.
>   - Added enable rollback of first clock if second fails to enable.
> v2:
>   - Use new devm_clk_get_optional() function as it simplifies handling when
>     the optional clock is not present.
> ---
>   drivers/i2c/busses/i2c-designware-common.c  | 18 ++++++++++++++++--
>   drivers/i2c/busses/i2c-designware-core.h    |  2 ++
>   drivers/i2c/busses/i2c-designware-platdrv.c |  5 +++++
>   3 files changed, 23 insertions(+), 2 deletions(-)
> 
Build & boot tested on linux-next that has the required commit
60b8f0ddf1a9 ("clk: Add (devm_)clk_get_optional() functions").

Acked-by: Jarkko Nikula <jarkko.nikula@...ux.intel.com>
Tested-by: Jarkko Nikula <jarkko.nikula@...ux.intel.com>