lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 1 Mar 2019 14:59:54 +0000
From:   Erwan Velu <>
To:     "Elliott, Robert (Persistent Memory)" <>,
        Erwan Velu <>
CC:     Don Brace <>,
        "James E.J. Bottomley" <>,
        "Martin K. Petersen" <>,
        "open list:MICROSEMI SMART ARRAY SMARTPQI DRIVER (smartpqi)" 
        "open list:MICROSEMI SMART ARRAY SMARTPQI DRIVER (smartpqi)" 
        open list <>
Subject: Re: [PATCH] scsi: smartpqi_init: Reporting 'logical unit failure'

> Be careful printing errors per-IO; you could get thousands of them if things go bad.
> The block layer print_req_error() uses printk_ratelimited(KERN_ERR) for that reason,
> and the SCSI layer scsi_io_completion_action() maintains a ratelimit on its own.
> The dev_err_ratelimited() macro might be a good fit here.

Thanks for the tip. I updated the patch and send a V2 for that.

I adjusted also to commit message to make it more explicit.

Thanks for the review.


Powered by blists - more mailing lists