lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Fri, 1 Mar 2019 16:18:04 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Oryan Perlmutter <oryan.perl1997@...il.com>
Cc:     martyn@...chs.me.uk, manohar.vanga@...il.com,
        devel@...verdev.osuosl.org, trivial@...nel.org,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Coding style fixes on vme_user.c trivial

On Fri, Mar 01, 2019 at 04:27:25PM +0200, Oryan Perlmutter wrote:
> drivers/staging/devices: Coding style fixes found at file vme_user.c.


Your subject line, and this changelog text, need a lot of work.  Please
look at the other patches that have been accepted for this driver as
examples of how to do this properly.

> 
> Signed-off-by: Oryan Perlmutter <oryan.perl1997@...il.com>
> ---
>  drivers/staging/vme/devices/vme_user.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c
> index 6a33aaa1a49f..4c7db4f5f15e 100644
> --- a/drivers/staging/vme/devices/vme_user.c
> +++ b/drivers/staging/vme/devices/vme_user.c
> @@ -506,7 +506,7 @@ static int vme_user_match(struct vme_dev *vdev)
>  	int cur_slot = vme_slot_num(vdev);
>  
>  	for (i = 0; i < bus_num; i++)
> -		if ((cur_bus == bus[i]) && (cur_slot == vdev->num))
> +		if (cur_bus == bus[i] && cur_slot == vdev->num)

Personally, I like the original code here, it's more explicit as to what
is going on.

thanks,

greg k-h

Powered by blists - more mailing lists