linux-kernel - Re: [PATCH] usb: core: make default autosuspend delay configurable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190301162341.GC19937@kroah.com>
Date:   Fri, 1 Mar 2019 17:23:41 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Mans Rullgard <mans@...sr.com>
Cc:     linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: core: make default autosuspend delay configurable

On Fri, Mar 01, 2019 at 02:26:46PM +0000, Mans Rullgard wrote:
> Make the default autosuspend delay configurable at build time.
> This is useful for systems that require a non-standard value as
> it avoids relying on the command line being properly set.
> 
> Signed-off-by: Mans Rullgard <mans@...sr.com>
> ---
>  drivers/usb/core/Kconfig | 8 ++++++++
>  drivers/usb/core/usb.c   | 4 ++--
>  2 files changed, 10 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/core/Kconfig b/drivers/usb/core/Kconfig
> index 4d75d9a80001..38ed837538c4 100644
> --- a/drivers/usb/core/Kconfig
> +++ b/drivers/usb/core/Kconfig
> @@ -90,3 +90,11 @@ config USB_LEDS_TRIGGER_USBPORT
>  	  This driver allows LEDs to be controlled by USB events. Enabling this
>  	  trigger allows specifying list of USB ports that should turn on LED
>  	  when some USB device gets connected.
> +
> +config USB_AUTOSUSPEND_DELAY
> +	int "Default autosuspend delay"
> +	depends on USB
> +	default 2
> +	help
> +	  The default autosuspend delay in seconds.  Can be overridden
> +	  with the usbcore.autosuspend command line or module parameter.

As everyone is suddenly going to be hit with this for a new kernel
upate, you might want to put something in here that says:
	The default value Linux has always had is 2 seconds.  Change
	this value if you want a different delay timeframe and can not
	modify the command line or module parameter option.

to make people a lot more comfortable with this change.

thanks,

greg k-h