linux-kernel - Re: [PATCH v3] cfi: fix deadloop in cfi_cmdset_0002.c do_write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 1 Mar 2019 20:56:58 +0100
From:   Boris Brezillon <boris.brezillon@...labora.com>
To:     Liu Jian <liujian56@...wei.com>
Cc:     <dwmw2@...radead.org>, <computersforpeace@...il.com>,
        <bbrezillon@...nel.org>, <marek.vasut@...il.com>, <richard@....at>,
        <joakim.tjernlund@...inera.com>, <ikegami@...ied-telesis.co.jp>,
        <keescook@...omium.org>, <vigneshr@...com>,
        <linux-mtd@...ts.infradead.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] cfi: fix deadloop in cfi_cmdset_0002.c
 do_write_buffer

The "mtd: " prefix is still missing. Should be "mtd: cfi: ". If you
send a new version, please fix that.

Thanks,

Boris

On Tue, 26 Feb 2019 22:00:48 +0800
Liu Jian <liujian56@...wei.com> wrote:

> In function do_write_buffer(), in the for loop, there is a case
> chip_ready() returns 1 while chip_good() returns 0, so it never
> break the loop.
> To fix this, chip_good() is enough and it should timeout if it stay
> bad for a while.
> 
> Fixes: dfeae1073583("mtd: cfi_cmdset_0002: Change write buffer to check correct value")
> Signed-off-by: Yi Huaijie <yihuaijie@...wei.com>
> Signed-off-by: Liu Jian <liujian56@...wei.com>
> Reviewed-by: Tokunori Ikegami <ikegami_to@...oo.co.jp>
> ---
> v2->v3:
> Follow Vignesh's advice:
> add one more check for check_good() even when time_after() returns true.
> 
>  drivers/mtd/chips/cfi_cmdset_0002.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/chips/cfi_cmdset_0002.c b/drivers/mtd/chips/cfi_cmdset_0002.c
> index 72428b6..3da2376 100644
> --- a/drivers/mtd/chips/cfi_cmdset_0002.c
> +++ b/drivers/mtd/chips/cfi_cmdset_0002.c
> @@ -1876,7 +1876,7 @@ static int __xipram do_write_buffer(struct map_info *map, struct flchip *chip,
>  			continue;
>  		}
>  
> -		if (time_after(jiffies, timeo) && !chip_ready(map, adr))
> +		if (time_after(jiffies, timeo) && !chip_good(map, adr, datum))
>  			break;
>  
>  		if (chip_good(map, adr, datum)) {