linux-kernel - Re: [PATCH v3 06/12] usb: dwc3: Increase timeout for CmdAct cleared by device controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 2 Mar 2019 17:47:23 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Yu Chen <chenyu56@...wei.com>
Cc:     USB <linux-usb@...r.kernel.org>,
        devicetree <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        John Stultz <john.stultz@...aro.org>,
        Suzhuangluan <suzhuangluan@...ilicon.com>,
        Kongfei <kongfei@...ilicon.com>, liuyu712@...ilicon.com,
        wanghu17@...ilicon.com, butao@...ilicon.com,
        Yao Chen <chenyao11@...wei.com>, fangshengzhou@...ilicon.com,
        lipengcheng8@...wei.com, songxiaowei <songxiaowei@...ilicon.com>,
        xu yiping <xuyiping@...ilicon.com>, xuyoujun4@...wei.com,
        yudongbin@...ilicon.com, zangleigang@...ilicon.com,
        Felipe Balbi <balbi@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Binghui Wang <wangbinghui@...ilicon.com>
Subject: Re: [PATCH v3 06/12] usb: dwc3: Increase timeout for CmdAct cleared
 by device controller

On Sat, Mar 2, 2019 at 11:06 AM Yu Chen <chenyu56@...wei.com> wrote:
>
> It needs more time for the device controller to clear the CmdAct of
> DEPCMD on Hisilicon Kirin Soc.
>

5x times more? Can you provide more specific details on that?

> Cc: Andy Shevchenko <andy.shevchenko@...il.com>
> Cc: Felipe Balbi <balbi@...nel.org>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: John Stultz <john.stultz@...aro.org>
> Cc: Binghui Wang <wangbinghui@...ilicon.com>
> Signed-off-by: Yu Chen <chenyu56@...wei.com>
> ---
>  drivers/usb/dwc3/gadget.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
> index 6c9b76bcc2e1..84d701b37171 100644
> --- a/drivers/usb/dwc3/gadget.c
> +++ b/drivers/usb/dwc3/gadget.c
> @@ -270,7 +270,7 @@ int dwc3_send_gadget_ep_cmd(struct dwc3_ep *dep, unsigned cmd,
>  {
>         const struct usb_endpoint_descriptor *desc = dep->endpoint.desc;
>         struct dwc3             *dwc = dep->dwc;
> -       u32                     timeout = 1000;
> +       u32                     timeout = 5000;
>         u32                     saved_config = 0;
>         u32                     reg;
>
> --
> 2.15.0-rc2
>


-- 
With Best Regards,
Andy Shevchenko