linux-kernel - Re: [PATCH v2] mm/memory.c: do_fault: avoid usage of stale vm_area

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190302184544.GM14054@worktop.programming.kicks-ass.net>
Date:   Sat, 2 Mar 2019 19:45:44 +0100
From:   Peter Zijlstra <peterz@...radead.org>
To:     Jan Stancek <jstancek@...hat.com>
Cc:     linux-mm@...ck.org, akpm@...ux-foundation.org, willy@...radead.org,
        riel@...riel.com, mhocko@...e.com, ying.huang@...el.com,
        jrdr.linux@...il.com, jglisse@...hat.com,
        aneesh.kumar@...ux.ibm.com, david@...hat.com, aarcange@...hat.com,
        raquini@...hat.com, rientjes@...gle.com, kirill@...temov.name,
        mgorman@...hsingularity.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] mm/memory.c: do_fault: avoid usage of stale
 vm_area_struct

On Sat, Mar 02, 2019 at 07:19:39PM +0100, Jan Stancek wrote:
>  static vm_fault_t do_fault(struct vm_fault *vmf)
>  {
>  	struct vm_area_struct *vma = vmf->vma;
> +	struct mm_struct *vm_mm = READ_ONCE(vma->vm_mm);

Would this not need a corresponding WRITE_ONCE() in vma_init() ?