linux-kernel - Re: [PATCH v2] PCIE/PME: fix possible use-after-free on remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAErSpo74LHWaHtjPGthyNvAgrq7wb0G0dbh9krzMQH0cK-DE9g@mail.gmail.com>
Date:   Fri, 1 Mar 2019 18:11:12 -0600
From:   Bjorn Helgaas <bhelgaas@...gle.com>
To:     Sven Van Asbroeck <thesven73@...il.com>
Cc:     Linux PCI <linux-pci@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Sinan Kaya <okaya@...nel.org>,
        Frederick Lawler <fred@...dlawl.com>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Keith Busch <keith.busch@...el.com>,
        "Rafael J . Wysocki" <rafael.j.wysocki@...el.com>
Subject: Re: [PATCH v2] PCIE/PME: fix possible use-after-free on remove

On Fri, Mar 1, 2019 at 10:54 AM Sven Van Asbroeck <thesven73@...il.com> wrote:
>
> In remove(), ensure that the pme work cannot run after kfree()
> is called. Otherwise, this could result in a use-after-free.
>
> This issue was detected with the help of Coccinelle.
>
> Cc: Sinan Kaya <okaya@...nel.org>
> Cc: Frederick Lawler <fred@...dlawl.com>
> Cc: Mika Westerberg <mika.westerberg@...ux.intel.com>
> Cc: Keith Busch <keith.busch@...el.com>
> Cc: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> Signed-off-by: Sven Van Asbroeck <TheSven73@...il.com>

Applied to pci/pm for v5.1, thanks!

> ---
>  drivers/pci/pcie/pme.c | 1 +
>  1 file changed, 1 insertion(+)
>
> v2:
>         rebased against Bjorn Helgaas's pcm/pm branch at
>         git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git
>
> diff --git a/drivers/pci/pcie/pme.c b/drivers/pci/pcie/pme.c
> index efa5b552914b..54d593d10396 100644
> --- a/drivers/pci/pcie/pme.c
> +++ b/drivers/pci/pcie/pme.c
> @@ -437,6 +437,7 @@ static void pcie_pme_remove(struct pcie_device *srv)
>
>         pcie_pme_disable_interrupt(srv->port, data);
>         free_irq(srv->irq, srv);
> +       cancel_work_sync(&data->work);
>         kfree(data);
>  }
>
> --
> 2.17.1
>