linux-kernel - Re: [PATCH] fs: use KERNEL_DS instead of get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190302034017.GM2217@ZenIV.linux.org.uk>
Date:   Sat, 2 Mar 2019 03:40:17 +0000
From:   Al Viro <viro@...iv.linux.org.uk>
To:     Jann Horn <jannh@...gle.com>
Cc:     linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH] fs: use KERNEL_DS instead of get_ds()

On Fri, Mar 01, 2019 at 09:08:35PM +0100, Jann Horn wrote:
> get_ds() is a legacy name for KERNEL_DS; all architectures #define it to
> KERNEL_DS,

not quite - h8300 and m68k have it as (equivalent) static inline.

> and almost every user of set_fs() uses the name KERNEL_DS.
> 
> Let the VFS also use KERNEL_DS so that we can get rid of get_ds() at some
> point.

No objections, but that kind of stuff might be better done in a different
way: ask Linus to run this

git grep -n -w get_ds | tr ':' ' ' | while read file line junk; do
	case "$file" in
	*include*|tools*)
		;;
	*)
		ed $file <<EOF
${line}s/get_ds()/KERNEL_DS/
w
q
EOF
		;;
	esac
done

just before -rc1, then follow it up with "kill unused get_ds()" patch
right after -rc1.