[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sat, 2 Mar 2019 20:04:49 -0700
From: Nathan Chancellor <natechancellor@...il.com>
To: Louis Taylor <louis@...gniz.eu>
Cc: tglx@...utronix.de, mingo@...hat.com, bp@...en8.de, hpa@...or.com,
x86@...nel.org, fanc.fnst@...fujitsu.com, bhe@...hat.com,
kirill.shutemov@...ux.intel.com, linux-kernel@...r.kernel.org,
clang-built-linux@...glegroups.com, ndesaulniers@...gle.com,
jflat@...omium.org
Subject: Re: [PATCH] x86/KASLR: always return a value from process_mem_region
On Sat, Mar 02, 2019 at 06:49:29PM +0000, Louis Taylor wrote:
> When compiling with -Wreturn-type, clang warns:
>
> arch/x86/boot/compressed/kaslr.c:704:1: warning: control may reach end of
> non-void function [-Wreturn-type]
>
> This function's return statement should probably have been placed
> outside the #endif, so move it there
>
> Link: https://github.com/ClangBuiltLinux/linux/issues/360
> Signed-off-by: Louis Taylor <louis@...gniz.eu>
Reviewed-by: Nathan Chancellor <natechancellor@...il.com>
Thanks for the patch!
> ---
> arch/x86/boot/compressed/kaslr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/boot/compressed/kaslr.c b/arch/x86/boot/compressed/kaslr.c
> index fa0332dda9f2..2e53c056ba20 100644
> --- a/arch/x86/boot/compressed/kaslr.c
> +++ b/arch/x86/boot/compressed/kaslr.c
> @@ -697,8 +697,8 @@ static bool process_mem_region(struct mem_vector *region,
> return 1;
> }
> }
> - return 0;
> #endif
> + return 0;
> }
>
> #ifdef CONFIG_EFI
> --
> 2.20.1
Powered by blists - more mailing lists