linux-kernel - Re: [PATCH -next] workqueue: fix a memory leak in wq->lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 3 Mar 2019 10:19:40 -0800
From:   Bart Van Assche <bvanassche@....org>
To:     Qian Cai <cai@....pw>, tj@...nel.org, jiangshanlai@...il.com
Cc:     peterz@...radead.org, mingo@...hat.com, will.deacon@....com,
        catalin.marinas@....com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] workqueue: fix a memory leak in wq->lock_name

On 3/3/19 6:34 AM, Qian Cai wrote:
> diff --git a/kernel/workqueue.c b/kernel/workqueue.c
> index 497900263dbc..e780bf73eced 100644
> --- a/kernel/workqueue.c
> +++ b/kernel/workqueue.c
> @@ -3445,6 +3445,8 @@ static void wq_init_lockdep(struct workqueue_struct *wq)
>   	lock_name = kasprintf(GFP_KERNEL, "%s%s", "(wq_completion)", wq->name);
>   	if (!lock_name)
>   		lock_name = wq->name;
> +
> +	wq->lock_name = lock_name;
>   	lockdep_init_map(&wq->lockdep_map, lock_name, &wq->key, 0);
>   }

Not sure how this got overlooked. Anyway:

Reviewed-by: Bart Van Assche <bvanassche@....org>