linux-kernel - Re: [PATCH 2/2] spi: dw: Add support for an optional interface clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190304000433.GO23441@sirena.org.uk>
Date:   Mon, 4 Mar 2019 00:04:33 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Gareth Williams <gareth.williams.jx@...esas.com>
Cc:     Phil Edworthy <phil.edworthy@...esas.com>,
        linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] spi: dw: Add support for an optional interface clock

On Thu, Feb 28, 2019 at 01:25:42PM +0000, Gareth Williams wrote:
> From: Phil Edworthy <phil.edworthy@...esas.com>
> 
> The Synopsys SSI Controller has an interface clock, but most SoCs hide 
> this away. However, on some SoCs you need to explicity enable the 
> interface clock in order to access the registers. Therefore, add 
> support for an optional interface clock.

This doesn't build for me:

  CC      drivers/spi/spi-dw-mmio.o
drivers/spi/spi-dw-mmio.c: In function ‘dw_spi_mmio_probe’:
drivers/spi/spi-dw-mmio.c:177:18: error: implicit declaration of function ‘devm_clk_get_optional’; did you mean ‘devm_gpiod_get_optional’? [-Werror=implicit-function-declaration]
  dwsmmio->pclk = devm_clk_get_optional(&pdev->dev, "pclk");
                  ^~~~~~~~~~~~~~~~~~~~~
                  devm_gpiod_get_optional
drivers/spi/spi-dw-mmio.c:177:16: warning: assignment to ‘struct clk *’ from ‘int’ makes pointer from integer without a cast [-Wint-conversion]
  dwsmmio->pclk = devm_clk_get_optional(&pdev->dev, "pclk");
                ^

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)