linux-kernel - Re: rpi-b-rev2 can't detect hdmi display due to wrong hpd gpio pull in dts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8736o2tmg0.fsf@anholt.net>
Date:   Mon, 04 Mar 2019 12:27:11 -0800
From:   Eric Anholt <eric@...olt.net>
To:     Helen Koike <helen.koike@...labora.com>
Cc:     linux-rpi-kernel@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        stefan.wahren@...e.com, linus.walleij@...aro.org, lkundrak@...sk,
        bcm-kernel-feedback-list@...adcom.com, devicetree@...r.kernel.org,
        kernel@...labora.com
Subject: Re: rpi-b-rev2 can't detect hdmi display due to wrong hpd gpio pull in dts

Helen Koike <helen.koike@...labora.com> writes:

> Hello,
>
> I have a rpi-b-rev2 (two holes, 512M) and when I was trying to test vc4
> driver, the HDMI wans't being detected.
>
> So I changed the hpd-gpios from ACTIVE_LOW to ACTIVE_HIGH and now it
> works correctly. I can see that modeprint from libdrm detects correctly
> when the display is plugged and when it is unpluggled.
>
> So I was wondering if this is just in my board or if there is an error
> in the dts (which I think it's unlikely).
>
> In any case I am dropping this email here in case anyone else see this
> problem, if you do, try appliying the patch below.

We even have the GPIO labeled as "HDMI_HPD_P" above, and dt-blob.dts
agrees.

Reviewed-by: Eric Anholt <eric@...olt.net>

Thanks!  If Stefan doesn't pick this up shortly, I can.

Download attachment "signature.asc" of type "application/pgp-signature" (833 bytes)