linux-kernel - Re: [PATCH v2 1/2] soc: bcm: bcm2835-pm: Fix PM_IMAGE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c4625edb-be9d-97eb-0139-29e940901d91@gmail.com>
Date:   Mon, 4 Mar 2019 13:08:20 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Eric Anholt <eric@...olt.net>,
        Florian Fainelli <f.fainelli@...il.com>
Cc:     linux-rpi-kernel@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Stefan Wahren <stefan.wahren@...e.com>,
        bcm-kernel-feedback-list@...adcom.com
Subject: Re: [PATCH v2 1/2] soc: bcm: bcm2835-pm: Fix PM_IMAGE_PERI power
 domain support.

On 2/20/19 10:19 AM, Eric Anholt wrote:
> We don't have ASB master/slave regs for this domain, so just skip that
> step.
> 
> Signed-off-by: Eric Anholt <eric@...olt.net>
> Fixes: 670c672608a1 ("soc: bcm: bcm2835-pm: Add support for power domains under a new binding.")

Eric, do you want put that in a pull request for me to send to the ARM
SoC maintainers?

> ---
>  drivers/soc/bcm/bcm2835-power.c | 14 ++++++++++++--
>  1 file changed, 12 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/soc/bcm/bcm2835-power.c b/drivers/soc/bcm/bcm2835-power.c
> index 48412957ec7a..4a1b99b773c0 100644
> --- a/drivers/soc/bcm/bcm2835-power.c
> +++ b/drivers/soc/bcm/bcm2835-power.c
> @@ -150,7 +150,12 @@ struct bcm2835_power {
>  
>  static int bcm2835_asb_enable(struct bcm2835_power *power, u32 reg)
>  {
> -	u64 start = ktime_get_ns();
> +	u64 start;
> +
> +	if (!reg)
> +		return 0;
> +
> +	start = ktime_get_ns();
>  
>  	/* Enable the module's async AXI bridges. */
>  	ASB_WRITE(reg, ASB_READ(reg) & ~ASB_REQ_STOP);
> @@ -165,7 +170,12 @@ static int bcm2835_asb_enable(struct bcm2835_power *power, u32 reg)
>  
>  static int bcm2835_asb_disable(struct bcm2835_power *power, u32 reg)
>  {
> -	u64 start = ktime_get_ns();
> +	u64 start;
> +
> +	if (!reg)
> +		return 0;
> +
> +	start = ktime_get_ns();
>  
>  	/* Enable the module's async AXI bridges. */
>  	ASB_WRITE(reg, ASB_READ(reg) | ASB_REQ_STOP);
> 


-- 
Florian